Change in vdsm[master]: vdsm-tool: Add logging and verbosity flags
dkuznets at redhat.com
dkuznets at redhat.com
Sun May 11 10:08:59 UTC 2014
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-tool: Add logging and verbosity flags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27481/1/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Line 137: print "\t\tProvide verbose logs."
Line 138: print " -a, --append"
Line 139: print "\t\tAppend to logfile instead of truncating it",
Line 140: print "(if logging to a file)."
Line 141:
> why not to use argparse?
If we use argparse, I'd urge to have a sub parser for each command for a single unified usage, but this is really big change to make.
Line 142: for mod_name, mod_desc in tool_modules:
Line 143: _usage_module(mod_name, mod_desc)
Line 144:
Line 145: print
--
To view, visit http://gerrit.ovirt.org/27481
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list