Change in vdsm[master]: tests: Ensure cleanup when tests fail

danken at redhat.com danken at redhat.com
Fri May 9 15:14:11 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tests: Ensure cleanup when tests fail
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/27505/3/tests/miscTests.py
File tests/miscTests.py:

Line 814: 
Line 815:             # clean it
Line 816:             fileUtils.cleanupdir(dirty)
Line 817: 
Line 818:             self.assertFalse(os.path.lexists(dirty))
much better than my suggested hack.
Line 819: 
Line 820:     def testEmptyDir(self):
Line 821:         """
Line 822:         Test if method can delete an empty dir.


-- 
To view, visit http://gerrit.ovirt.org/27505
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If81cd46b37dd135d8584fde996d0d1d3f8f550a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list