Change in vdsm[master]: ifcfg: set onboot=no when persistence is 'unified'

asegurap at redhat.com asegurap at redhat.com
Fri May 9 13:30:33 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ifcfg: set onboot=no when persistence is 'unified'
......................................................................


Patch Set 1: Verified+1

Manually verified by setting net_persistence to 'unified' and then doing:

    toniel602 vdsm (9e73ac9) # vdsClient -s 0 addNetwork bridge=other nics=eth3 bootproto=dhcp
    Done
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-eth3                                          
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=eth3
    ONBOOT=no
    HWADDR=00:01:a4:ac:87:95
    BRIDGE=other
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-other                                     
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=other
    ONBOOT=no
    TYPE=Bridge
    DELAY=0
    STP=off
    BOOTPROTO=dhcp
    DEFROUTE=no
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) # vdsClient -s 0 addNetwork bridge=otherbrless nics=eth4 bootproto=dhcp bridged=False
    Done
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-eth4 
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=eth4
    ONBOOT=no
    HWADDR=00:01:a4:ac:87:96
    BOOTPROTO=dhcp
    DEFROUTE=no
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) #                                                                
    toniel602 vdsm (9e73ac9) #                                                                           
    toniel602 vdsm (9e73ac9) # ipython
    Python 2.6.6 (r266:84292, Nov 21 2013, 10:50:32) 
    Type "copyright", "credits" or "license" for more information.

    IPython 0.10 -- An enhanced Interactive Python.
    ?         -> Introduction and overview of IPython's features.
    %quickref -> Quick reference.
    help      -> Python's own help system.
    object?   -> Details about 'object'. ?object also works, ?? prints more.

    In [1]: from vdsm import vdscli

    In [2]: c = vdscli.connect()

    In [3]: c.setupNetworks({'otherbond':{'bonding': 'bond0', 'bootproto': 'dhcp'}}, {'bond0': {'nics': ['eth5', 'eth6'], 'options': 'mode=1'}}, {'connectivityCheck': False})
    Out[3]: {'status': {'code': 0, 'message': 'Done'}}

    In [4]: 
    Do you really want to exit ([y]/n)? 
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-eth5
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=eth5
    ONBOOT=no
    HWADDR=00:01:a4:ac:87:8a
    MASTER=bond0
    SLAVE=yes
    MTU=1500
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-eth6
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=eth6
    ONBOOT=no
    HWADDR=00:01:a4:ac:87:8b
    MASTER=bond0
    SLAVE=yes
    MTU=1500
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-bond0
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=bond0
    ONBOOT=no
    BONDING_OPTS=mode=1
    BRIDGE=otherbond
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) # cat /etc/sysconfig/network-scripts/ifcfg-otherbond
    # Generated by VDSM version 4.14.1-301.git9e73ac9.el6
    DEVICE=otherbond
    ONBOOT=no
    TYPE=Bridge
    DELAY=0
    STP=off
    BOOTPROTO=dhcp
    DEFROUTE=no
    NM_CONTROLLED=no
    toniel602 vdsm (9e73ac9) # vdsClient -s 0 setSafeNetworkConfig                                                
    Done
    toniel602 vdsm (9e73ac9) # reboot
    #                                                                                                                                                                                                                                             
    Broadcast message from root at toniel602.usersys.redhat.com
            (/dev/pts/0) at 15:19 ...

    The system is going down for reboot NOW!
    toniel602 vdsm (9e73ac9) # Connection to toniel602.usersys.redhat.com closed by remote host.
    Connection to toniel602.usersys.redhat.com closed.
    ~/c/vdsm ❯❯❯ ssh toniel602
    toniel602 ~ # scaps | cat
            ...
            bondings = {'bond0': {'addr': '',
                                  'cfg': {'BONDING_OPTS': 'mode=1',
                                          'BRIDGE': 'otherbond',
                                          'DEVICE': 'bond0',
                                          'NM_CONTROLLED': 'no',
                                          'ONBOOT': 'no'},
                                  'hwaddr': '00:01:a4:ac:87:8a',
                                  'ipv6addrs': ['fe80::201:a4ff:feac:878a/64'],
                                  'mtu': '1500',
                                  'netmask': '',
                                  'slaves': ['eth5', 'eth6']},
                        'bond1': {'addr': '',
                                  'cfg': {},
                                  'hwaddr': '00:00:00:00:00:00',
                                  'ipv6addrs': [],
                                  'mtu': '1500',
                                  'netmask': '',
                                  'slaves': []},
                        'bond2': {'addr': '',
                                  'cfg': {},
                                  'hwaddr': '00:00:00:00:00:00',
                                  'ipv6addrs': [],
                                  'mtu': '1500',
                                  'netmask': '',
                                  'slaves': []},
                        'bond3': {'addr': '',
                                  'cfg': {},
                                  'hwaddr': '00:00:00:00:00:00',
                                  'ipv6addrs': [],
                                  'mtu': '1500',
                                  'netmask': '',
                                  'slaves': []},
                        'bond4': {'addr': '',
                                  'cfg': {},
                                  'hwaddr': '00:00:00:00:00:00',
                                  'ipv6addrs': [],
                                  'mtu': '1500',
                                  'netmask': '',
                                  'slaves': []}}
            bridges = {'other': {'addr': '10.34.62.50',
                                 'cfg': {'BOOTPROTO': 'dhcp',
                                         'DEFROUTE': 'no',
                                         'DELAY': '0',
                                         'DEVICE': 'other',
                                         'NM_CONTROLLED': 'no',
                                         'ONBOOT': 'no',
                                         'STP': 'off',
                                         'TYPE': 'Bridge'},
                                 'gateway': '10.34.63.254',
                                 'ipv6addrs': ['2620:52:0:223c:201:a4ff:feac:8795/64',
                                               'fe80::201:a4ff:feac:8795/64'],
                                 'ipv6gateway': 'fe80:52:0:223c::3fe',
                                 'mtu': '1500',
                                 'netmask': '255.255.252.0',
                                 'opts': {'ageing_time': '29995',
                                          'bridge_id': '8000.0001a4ac8795',
                                          'forward_delay': '0',
                                          'gc_timer': '3',
                                          'group_addr': '1:80:c2:0:0:0',
                                          'hash_elasticity': '4',
                                          'hash_max': '512',
                                          'hello_time': '199',
                                          'hello_timer': '103',
                                          'max_age': '1999',
                                          'multicast_last_member_count': '2',
                                          'multicast_last_member_interval': '99',
                                          'multicast_membership_interval': '25996',
                                          'multicast_querier': '0',
                                          'multicast_querier_interval': '25496',
                                          'multicast_query_interval': '12498',
                                          'multicast_query_response_interval': '999',
                                          'multicast_router': '1',
                                          'multicast_snooping': '1',
                                          'multicast_startup_query_count': '2',
                                          'multicast_startup_query_interval': '3124',
                                          'priority': '32768',
                                          'root_id': '8000.0001a4ac8795',
                                          'root_path_cost': '0',
                                          'root_port': '0',
                                          'stp_state': '0',
                                          'tcn_timer': '0',
                                          'topology_change': '0',
                                          'topology_change_detected': '0',
                                          'topology_change_timer': '0'},
                                 'ports': ['eth3'],
                                 'stp': 'off'},
                       'otherbond': {'addr': '10.34.60.192',
                                     'cfg': {'BOOTPROTO': 'dhcp',
                                             'DEFROUTE': 'no',
                                             'DELAY': '0',
                                             'DEVICE': 'otherbond',
                                             'NM_CONTROLLED': 'no',
                                             'ONBOOT': 'no',
                                             'STP': 'off',
                                             'TYPE': 'Bridge'},
                                     'gateway': '10.34.63.254',
                                     'ipv6addrs': ['2620:52:0:223c:201:a4ff:feac:878a/64',
                                                   'fe80::201:a4ff:feac:878a/64'],
                                     'ipv6gateway': 'fe80:52:0:223c::3fe',
                                     'mtu': '1500',
                                     'netmask': '255.255.252.0',
                                     'opts': {'ageing_time': '29995',
                                              'bridge_id': '8000.0001a4ac878a',
                                              'forward_delay': '0',
                                              'gc_timer': '3',
                                              'group_addr': '1:80:c2:0:0:0',
                                              'hash_elasticity': '4',
                                              'hash_max': '512',
                                              'hello_time': '199',
                                              'hello_timer': '103',
                                              'max_age': '1999',
                                              'multicast_last_member_count': '2',
                                              'multicast_last_member_interval': '99',
                                              'multicast_membership_interval': '25996',
                                              'multicast_querier': '0',
                                              'multicast_querier_interval': '25496',
                                              'multicast_query_interval': '12498',
                                              'multicast_query_response_interval': '999',
                                              'multicast_router': '1',
                                              'multicast_snooping': '1',
                                              'multicast_startup_query_count': '2',
                                              'multicast_startup_query_interval': '3124',
                                              'priority': '32768',
                                              'root_id': '8000.0001a4ac878a',
                                              'root_path_cost': '0',
                                              'root_port': '0',
                                              'stp_state': '0',
                                              'tcn_timer': '0',
                                              'topology_change': '0',
                                              'topology_change_detected': '0',
                                              'topology_change_timer': '0'},
                                     'ports': ['bond0'],
                                     'stp': 'off'}}
            ...
            networks = {'other': {'addr': '10.34.62.50',
                                  'bootproto4': 'dhcp',
                                  'bridged': True,
                                  'cfg': {'BOOTPROTO': 'dhcp',
                                          'DEFROUTE': 'no',
                                          'DELAY': '0',
                                          'DEVICE': 'other',
                                          'NM_CONTROLLED': 'no',
                                          'ONBOOT': 'no',
                                          'STP': 'off',
                                          'TYPE': 'Bridge'},
                                  'gateway': '10.34.63.254',
                                  'iface': 'other',
                                  'ipv6addrs': ['2620:52:0:223c:201:a4ff:feac:8795/64',
                                                'fe80::201:a4ff:feac:8795/64'],
                                  'ipv6gateway': 'fe80:52:0:223c::3fe',
                                  'mtu': '1500',
                                  'netmask': '255.255.252.0',
                                  'ports': ['eth3'],
                                  'stp': 'off'},
                        'otherbond': {'addr': '10.34.60.192',
                                      'bootproto4': 'dhcp',
                                      'bridged': True,
                                      'cfg': {'BOOTPROTO': 'dhcp',
                                              'DEFROUTE': 'no',
                                              'DELAY': '0',
                                              'DEVICE': 'otherbond',
                                              'NM_CONTROLLED': 'no',
                                              'ONBOOT': 'no',
                                              'STP': 'off',
                                              'TYPE': 'Bridge'},
                                      'gateway': '10.34.63.254',
                                      'iface': 'otherbond',
                                      'ipv6addrs': ['2620:52:0:223c:201:a4ff:feac:878a/64',
                                                    'fe80::201:a4ff:feac:878a/64'],
                                      'ipv6gateway': 'fe80:52:0:223c::3fe',
                                      'mtu': '1500',
                                      'netmask': '255.255.252.0',
                                      'ports': ['bond0'],
                                      'stp': 'off'},
                        'otherbrless': {'addr': '10.34.62.46',
                                        'bootproto4': 'dhcp',
                                        'bridged': False,
                                        'gateway': '10.34.63.254',
                                        'iface': 'eth4',
                                        'interface': 'eth4',
                                        'ipv6addrs': ['fe80::201:a4ff:feac:8796/64'],
                                        'ipv6gateway': '::',
                                        'mtu': '1500',
                                        'netmask': '255.255.252.0'}}
            nics = {'eth1': {'addr': '10.34.60.244',
                             'cfg': {'BOOTPROTO': 'dhcp',
                                     'DEVICE': 'eth1',
                                     'HWADDR': '00:01:a4:ac:87:02',
                                     'NM_CONTROLLED': 'yes',
                                     'ONBOOT': 'yes',
                                     'TYPE': 'Ethernet',
                                     'UUID': 'd835971f-3ce3-454a-8d25-d7e93b8c84fc'},
                             'hwaddr': '00:01:a4:ac:87:02',
                             'ipv6addrs': ['2620:52:0:223c:201:a4ff:feac:8702/64',
                                           'fe80::201:a4ff:feac:8702/64'],
                             'mtu': '1500',
                             'netmask': '255.255.252.0',
                             'speed': 0},
                    'eth2': {'addr': '',
                             'cfg': {},
                             'hwaddr': '00:01:a4:ac:87:01',
                             'ipv6addrs': [],
                             'mtu': '1500',
                             'netmask': '',
                             'speed': 0},
                    'eth3': {'addr': '',
                             'cfg': {'BRIDGE': 'other',
                                     'DEVICE': 'eth3',
                                     'HWADDR': '00:01:a4:ac:87:95',
                                     'NM_CONTROLLED': 'no',
                                     'ONBOOT': 'no'},
                             'hwaddr': '00:01:a4:ac:87:95',
                             'ipv6addrs': [],
                             'mtu': '1500',
                             'netmask': '',
                             'speed': 0},
                    'eth4': {'addr': '10.34.62.46',
                             'cfg': {'BOOTPROTO': 'dhcp',
                                     'DEFROUTE': 'no',
                                     'DEVICE': 'eth4',
                                     'HWADDR': '00:01:a4:ac:87:96',
                                     'NM_CONTROLLED': 'no',
                                     'ONBOOT': 'no'},
                             'hwaddr': '00:01:a4:ac:87:96',
                             'ipv6addrs': ['fe80::201:a4ff:feac:8796/64'],
                             'mtu': '1500',
                             'netmask': '255.255.252.0',
                             'speed': 0},
                    'eth5': {'addr': '',
                             'cfg': {'DEVICE': 'eth5',
                                     'HWADDR': '00:01:a4:ac:87:8a',
                                     'MASTER': 'bond0',
                                     'MTU': '1500',
                                     'NM_CONTROLLED': 'no',
                                     'ONBOOT': 'no',
                                     'SLAVE': 'yes'},
                             'hwaddr': '00:01:a4:ac:87:8a',
                             'ipv6addrs': [],
                             'mtu': '1500',
                             'netmask': '',
                             'permhwaddr': '00:01:A4:AC:87:8A',
                             'speed': 0},
                    'eth6': {'addr': '',
                             'cfg': {'DEVICE': 'eth6',
                                     'HWADDR': '00:01:a4:ac:87:8b',
                                     'MASTER': 'bond0',
                                     'MTU': '1500',
                                     'NM_CONTROLLED': 'no',
                                     'ONBOOT': 'no',
                                     'SLAVE': 'yes'},
                             'hwaddr': '00:01:a4:ac:87:8a',
                             'ipv6addrs': [],
                             'mtu': '1500',
                             'netmask': '',
                             'permhwaddr': '00:01:A4:AC:87:8B',
                             'speed': 0}}
            ...
            vlans = {}
            ...
    toniel602 ~ #

-- 
To view, visit http://gerrit.ovirt.org/27541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad8bbdcaeb1790b7955f3a407758ee41c68befa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list