Change in vdsm[master]: tests: Fix error handling when cleaning up temporaries

nsoffer at redhat.com nsoffer at redhat.com
Thu May 8 16:54:24 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: Fix error handling when cleaning up temporaries
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27504/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: tests: Fix error handling when cleaning up temporaries
Line 8: 
Line 9: Failing when removing a file system entry when the entry does not exists
Line 10: is a bad pattern in general. This is particularly bad in the test
> Deleting a missing file is akin to releasing an already-free lock. It's a s
How do you suggest to change the patch and/or the commit message so we can use it upstream?
Line 11: framework where we like to use the temporaryPath and namedTemporaryDir
Line 12: for testing code that remove files and directories.
Line 13: 
Line 14: This patch ignore ENOENT errors when removing temporary files and


-- 
To view, visit http://gerrit.ovirt.org/27504
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb77ec0e0bbd210b56ec305ccff4a78cb0fc117a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list