Change in vdsm[master]: caps: Repair collect numa information

fromani at redhat.com fromani at redhat.com
Thu May 8 06:18:39 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: caps: Repair collect numa information
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

mostly OK, just one note and -1 only for visibility.

http://gerrit.ovirt.org/#/c/27090/6/vdsm/caps.py
File vdsm/caps.py:

Line 223: memDict
minor nit:

please consider

    memInfo = utils.readMemInfo()
    return {
      'total': str(memInfo['MemTotal'] / 1024),
      'free': str(memInfo['MemFree'] / 1024)}


please also check the possible rounding oddities, e.g what if the host have 3.5 GiB of RAM? (not sure it is possible on recent/decent boxes) - avoid float if it is possible, if you address this.


-- 
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list