Change in vdsm[master]: vdsm_config: move download certificate

Alon Bar-Lev alonbl at redhat.com
Wed May 7 19:49:29 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: vdsm_config: move download certificate
......................................................................


Patch Set 33: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/26718/33/vdsm_reg/vdsm-reg-setup.in
File vdsm_reg/vdsm-reg-setup.in:

Line 243:         # delete it if not.
Line 244:         #
Line 245:         if fOK:
Line 246:             if not self._compare_fingerprint(self.engineWebCACert) and \
Line 247:                     os.path.exist(self.engineWebCACert)
not sure why we need both ifs... can be if ok and not ssss and os. ...
Line 248:                 ovirtfunctions.ovirt_safe_delete_config(
Line 249:                     self.engineWebCACert
Line 250:                 )
Line 251:                 os.unlink(self.engineWebCACert)


-- 
To view, visit http://gerrit.ovirt.org/26718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list