Change in vdsm[master]: replace configure_libvirt.py with python code.

mtayer at redhat.com mtayer at redhat.com
Wed May 7 14:15:01 UTC 2014


mooli tayer has posted comments on this change.

Change subject: replace configure_libvirt.py with python code.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/27298/3/tests/toolTests.py
File tests/toolTests.py:

Line 166:             ('QCONF', 'empty'),
Line 167:         )
Line 168:         self.assertFalse(libvirtConfigure.isconfigured())
Line 169: 
Line 170: 
> I plan more tests to test configure verb.(instead of those removed) also I 
Done
Line 171: class ConfigFileTests(TestCase):
Line 172:     def setUp(self):
Line 173:         fd, self.tname = tempfile.mkstemp()
Line 174:         os.close(fd)


-- 
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list