Change in vdsm[master]: vdsm-tool: Change exception reporting

dkuznets at redhat.com dkuznets at redhat.com
Wed May 7 06:46:08 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: vdsm-tool: Change exception reporting
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/26565/4/lib/vdsm/tool/__init__.py
File lib/vdsm/tool/__init__.py:

Line 27:         return fun
Line 28: 
Line 29: 
Line 30: class UsageError(RuntimeError):
Line 31:     """ Raise on runtime when user uses wrong vdsm-tool verb """
UsageError seems to indicate that the use used wrong command (and hence gets to read the usage and fix the command).
I am not familiar enough with all the code, but it seems that it is also thrown when verbs fail, which does not sound like a usage error, rather some find of failure.
Line 32: 
Line 33: 
Line 34: class NotRootError(UsageError):
Line 35:     def __init__(self):


-- 
To view, visit http://gerrit.ovirt.org/26565
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I467d1e5ef7503312cde6e013aacb68dc2d46dd37
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list