Change in vdsm[master]: profile: Add couple of tests

danken at redhat.com danken at redhat.com
Tue May 6 12:01:00 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: profile: Add couple of tests
......................................................................


profile: Add couple of tests

We plan to modify the profiler so it will be useable for the functional
tests, where we like to have one profile per test, instead of the
application wide profile.

This patch adds couple of tests to make it easier to modify the profiler
without breaking anything.

The profile filename and format are now module private constants, so we
can easily override them during the tests.

Change-Id: I0dedc21993972ec25881f46f0b365445ed494aac
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27328
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/profile.py
M tests/Makefile.am
A tests/profileTests.py
3 files changed, 113 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/27328
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0dedc21993972ec25881f46f0b365445ed494aac
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list