Change in vdsm[master]: sourcerouting: fix _getRoute not to include local routes

danken at redhat.com danken at redhat.com
Tue May 6 08:31:26 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sourcerouting: fix _getRoute not to include local routes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/27262/2//COMMIT_MSG
Commit Message:

Line 33:     240.0.0.0/24 via 240.0.0.1 dev test-network
Line 34:     default via 240.0.0.254 dev test-network
Line 35:     broadcast 127.255.255.255 dev lo  proto kernel  scope link  src 127.0.0.1
Line 36:     broadcast 240.0.0.255 dev test-network  proto kernel  scope link  src 240.0.0.1
Line 37:     local 10.34.60.31 dev eth1  proto kernel  scope host  src 10.34.60.31
> The problem is that with the current code that does show table X, when X is
oh, so there's an iproute2 bug here... please report it, and refer to it in the commit message.
Line 38:     local 240.0.0.1 dev test-network  proto kernel  scope host  src 240.0.0.1
Line 39:     broadcast 240.0.0.0 dev test-network  proto kernel  scope link  src 240.0.0.1
Line 40:     broadcast 10.34.60.0 dev eth1  proto kernel  scope link  src 10.34.60.31
Line 41:     broadcast 10.34.63.255 dev eth1  proto kernel  scope link  src 10.34.60.31


-- 
To view, visit http://gerrit.ovirt.org/27262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d43c8a2077e40b8b4314f02ea17bc3968c42b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list