Change in vdsm[master]: [WIP] Pyroute2 network configurator

asegurap at redhat.com asegurap at redhat.com
Tue May 6 08:14:54 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: [WIP] Pyroute2 network configurator
......................................................................


Patch Set 2:

It looks good, the problem I see is the lack of consistency between sometimes using interface.commit() and others using with interface.

Can you explain why sometimes you use one and sometimes the other?

-- 
To view, visit http://gerrit.ovirt.org/27063
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73b56980dd774bc1b97b3309877426f1b1a5309b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Robert Cernak <robocernak at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <celebdor at gmail.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev at gmail.com>
Gerrit-Reviewer: Robert Cernak <robocernak at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list