Change in vdsm[master]: caps: Repair collect numa information

danken at redhat.com danken at redhat.com
Tue May 6 07:18:23 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: caps: Repair collect numa information
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/27090/4/vdsm/caps.py
File vdsm/caps.py:

Line 202:     Get the memory stats of a specified numa node, the unit is MiB.
Line 203: 
Line 204:     :param cell: the index of numa node.
Line 205:     :type cell: int
Line 206:     :return: dict like {'total': '49141', 'free': '46783'}
Thanks for fixing the units. However, the fix is unrelated to this patch.  This may confuse reviewers in the future. Please dedicate a new change for it.
Line 207:     """
Line 208:     cellMemInfo = libvirtconnection.get().getMemoryStats(cell, 0)
Line 209:     cellMemInfo['total'] = str(cellMemInfo['total'] / 1024)
Line 210:     cellMemInfo['free'] = str(cellMemInfo['free'] / 1024)


http://gerrit.ovirt.org/#/c/27090/4/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:

Line 721: # @cpus:        The cpu ids in this numa node. The cpu id is described in
Line 722: #               libvirt's capabilities api. When hyper-thread is enabled,
Line 723: #               one cpu core id will correspond to two sibling cpu ids.
Line 724: #
Line 725: # @totalMemory: The total memory of this numa node
Please document the unit here.
Line 726: #
Line 727: # Since: 4.15.0
Line 728: ##
Line 729: {'type': 'NumaNode',


Line 726: #
Line 727: # Since: 4.15.0
Line 728: ##
Line 729: {'type': 'NumaNode',
Line 730:  'data': {'cpus': ['uint'], 'totalMemory': 'str'}}
It is confusing and counterintuitive, but please keep this as "uint" despite the actual type passed via xmlrpc (other similar numbers have the same odd behavior).
Line 731: 
Line 732: ##
Line 733: # @HookScriptInfo:
Line 734: #


-- 
To view, visit http://gerrit.ovirt.org/27090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb70231c81e75d29107f4ea89367aa33d8e85bad
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list