Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes

smizrahi at redhat.com smizrahi at redhat.com
Sun May 4 08:11:36 UTC 2014


Saggi Mizrahi has posted comments on this change.

Change subject: Convert file metadata to use ioprocess for read/writes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27267/1/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 137:             self.glob = _ioprocessGlob(ioproc)
Line 138:             self.fileUtils.validateAccess = \
Line 139:                 _ioprocessFileUtils(ioproc).validateAccess
Line 140:             self.directReadLines = partial(directReadLines, ioproc)
Line 141:             self.writeLines = partial(writeLines, ioproc)
What about rename?
Line 142: 
Line 143:     def __getattr__(self, name):
Line 144:         # Root modules is fake, we need to remove it
Line 145:         fullName = ".".join(self._modName.split(".")[1:] + [name])


-- 
To view, visit http://gerrit.ovirt.org/27267
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86beb53885dc935ad473498208e486895eab8315
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list