Change in vdsm[master]: spbackends: do not set spmRole on forceFreeSpm

amureini at redhat.com amureini at redhat.com
Sun May 4 06:34:16 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: spbackends: do not set spmRole on forceFreeSpm
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27318/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Setting the spmRole to SPM_FREE on forceFreeSpm is harmful. In fact the
Line 10: release of the spm role (SPM_ACQUIRED) should go through the stopSpm
Line 11: procedure where the master filesystem is unmounted, etc.
Line 12: 
> Can you elaborate here on when this harmful code was added and why? Just to
I wonder if it's worth adding

Relates-To: https://bugzilla.redhat.com/show_bug.cgi?id=1082365
Line 13: Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec


-- 
To view, visit http://gerrit.ovirt.org/27318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list