Change in vdsm[master]: tool.nwfilter: do not close a connection twice

danken at redhat.com danken at redhat.com
Sat May 3 08:48:33 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tool.nwfilter: do not close a connection twice
......................................................................


tool.nwfilter: do not close a connection twice

My commit eb2ef55534 caused all libvirtconnections to be closed when the
calling process exists. As reported by Nir on
http://gerrit.ovirt.org/27313 that commit has a bug and was sloppily
verified. As of eb2ef55534, no one outside the libvirtconnection module
should close a libvirt connection.

Change-Id: I9dfe4b98401fb2c352f87952e182fb8df06fd0e3
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27315
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M lib/vdsm/tool/nwfilter.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27315
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9dfe4b98401fb2c352f87952e182fb8df06fd0e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list