Change in vdsm[master]: profiling: Add an application wide profile

dougsland at redhat.com dougsland at redhat.com
Fri May 2 18:45:36 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: profiling: Add an application wide profile
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py
File lib/vdsm/profile.py:

Line 35: def start():
Line 36:     global yappi
Line 37:     if is_enabled():
Line 38:         logging.debug("Starting profiling")
Line 39:         import yappi
shouldn't we use try: import yappi ...? Users can enable it without the package installed in the system.
Line 40:         yappi.start()
Line 41: 
Line 42: 
Line 43: def stop():


-- 
To view, visit http://gerrit.ovirt.org/26113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I523f52c981f7bb34f3168d3117f00ed5eb6962f8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list