Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

laravot at redhat.com laravot at redhat.com
Fri May 2 09:20:12 UTC 2014


Liron Ar has posted comments on this change.

Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26358/3/vdsm/storage/spbackends.py
File vdsm/storage/spbackends.py:

Line 337:     def forceFreeSpm(self):
Line 338:         # DO NOT USE, STUPID, HERE ONLY FOR BC
Line 339:         # TODO: SCSI Fence the 'lastOwner'
Line 340:         self.setSpmStatus(LVER_INVALID, SPM_ID_FREE, __securityOverride=True)
Line 341:         self.pool.spmRole = SPM_FREE
> 2 things:
Fede, I agree that it seems as unneeded from first look.
But, that has been always the behavior here, we need to verify that there's no some corner case before changing it (here and on engine), which isn't something that i want to handle in this patch.

Let's agree on having the attribute errors issues fixed here which restores the current behavior to function, while the removal of this line will be inspected regardless on a further patch.
Line 342: 
Line 343:     @classmethod
Line 344:     def _getPoolMD(cls, domain):
Line 345:         # This might look disgusting but this makes it so that


-- 
To view, visit http://gerrit.ovirt.org/26358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list