Change in vdsm[master]: core: fixing attribute error on fenceSpmStorage

Federico Simoncelli fsimonce at redhat.com
Fri May 2 08:34:05 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26358/3/vdsm/storage/spbackends.py
File vdsm/storage/spbackends.py:

Line 337:     def forceFreeSpm(self):
Line 338:         # DO NOT USE, STUPID, HERE ONLY FOR BC
Line 339:         # TODO: SCSI Fence the 'lastOwner'
Line 340:         self.setSpmStatus(LVER_INVALID, SPM_ID_FREE, __securityOverride=True)
Line 341:         self.pool.spmRole = SPM_FREE
> why? we have no setter for it..i can add one instead if you prefer it.
2 things:

* yes if we want to maintain this we need a setter (and it should be handled in another patch without touching this)
* setting spmRole = SPM_FREE is harmful

In fact if the current host is the spm (SPM_ACQUIRED) setting it to SPM_FREE without going in stopSpm is going to generate all kind of problems.

forceFreeSpm is entirely pointless (when it's not harmful).
Line 342: 
Line 343:     @classmethod
Line 344:     def _getPoolMD(cls, domain):
Line 345:         # This might look disgusting but this makes it so that


-- 
To view, visit http://gerrit.ovirt.org/26358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list