Change in vdsm[master]: vdsm_config: move download certificate

dougsland at redhat.com dougsland at redhat.com
Fri May 2 01:36:41 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm_config: move download certificate
......................................................................


Patch Set 22:

(3 comments)

http://gerrit.ovirt.org/#/c/26718/22/vdsm_reg/deployUtil.py.in
File vdsm_reg/deployUtil.py.in:

Line 1666: 
Line 1667: def getRhevmCert(IP, port, output=None):
Line 1668:     """Aquire CA certificate from SSL handshake
Line 1669: 
Line 1670:     This certificate is saved to a file and later used
> the "output" arg name confused me. Please mention that it's the path to whe
Done
Line 1671:     to validate HTTPS connections with the engine web
Line 1672:     server.
Line 1673: 
Line 1674:     """


http://gerrit.ovirt.org/#/c/26718/22/vdsm_reg/vdsm-reg-setup.in
File vdsm_reg/vdsm-reg-setup.in:

Line 202:         else:
Line 203:             fOK = self.renameBridge()
Line 204:             logging.debug("execute: after renameBridge: %s", fOK)
Line 205: 
Line 206:         if fOK and os.path.exists(self.engineWebCACert) and \
> you have a similar, but different, treatment for unmatching certs, dependin
If engineWebCaCert exists and user provided the fingerprint and it doesn't match we remove the file and try to download it from engine and compare one more time. If it doesn't match again we exit.
Line 207:             self.cfg_fprint != "None":
Line 208:             if self.cfg_fprint.upper() != \
Line 209:                     deployUtil.generateFingerPrint(self.engineWebCACert):
Line 210:                 ovirtfunctions.ovirt_safe_delete_config(


Line 225:                 )
Line 226:                 if not download_certificate_succeeded and \
Line 227:                         self.cfg_fprint != "None":
Line 228:                     logging.info(
Line 229:                         "Cannot download Engine Web CA certificate file: " \
> trailing backslashes are unnecessary within parenthesis.
Done
Line 230:                         "%s:%s",
Line 231:                         self.vdcName,
Line 232:                         self.vdcPORT
Line 233:                     )


-- 
To view, visit http://gerrit.ovirt.org/26718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c025eedd2be92b9418ddbe01efc02c913af2a7
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list