Change in vdsm[master]: tests: initial tests for vm libvirt callbacks

danken at redhat.com danken at redhat.com
Thu May 1 13:51:32 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tests: initial tests for vm libvirt callbacks
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

tiny comment about naming.

and could you get us a core dump of

                           ../tests/run_tests_local.sh: line 10: 29456 Segmentation fault      PYTHONDONTWRITEBYTECODE=1 LC_ALL=C PYTHONPATH="../lib:../vdsm:../client:../vdsm_api:$PYTHONPATH" "$PYTHON_EXE" ../tests/testrunner.py --local-modules $@

http://gerrit.ovirt.org/#/c/27128/2/tests/vmTests.py
File tests/vmTests.py:

Line 772:             'guestCPUCount': -1}
Line 773: 
Line 774: 
Line 775: @contextmanager
Line 776: def FakeVM(params=None, devices=None, run=False):
I find "run" to be a too-vague term. "runcpu" sounds clearer.
Line 777:     with namedTemporaryDir() as tmpDir:
Line 778:         with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir + '/'),
Line 779:                                (libvirtconnection, 'get',
Line 780:                                 lambda x: ConnectionMock())]):


-- 
To view, visit http://gerrit.ovirt.org/27128
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059ef6cd42e8cfa03e2891dade00ff21e4c435bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list