Change in vdsm[master]: VmStatsThread: make _getNicStats testable

danken at redhat.com danken at redhat.com
Mon Mar 31 17:02:51 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: VmStatsThread: make _getNicStats testable
......................................................................


VmStatsThread: make _getNicStats testable

With this test, the shame of change Ie356d5f96c73b6 should not repeat.

Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25982
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 55 insertions(+), 26 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list