Change in vdsm[master]: init: Normalize shutdown timeout

danken at redhat.com danken at redhat.com
Mon Mar 31 16:59:43 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: init: Normalize shutdown timeout
......................................................................


init: Normalize shutdown timeout

On sysvinit, vdsm was killed 2 seconds after receiving a SIGTERM.
Currently clientIF check if shutdown is started only once every 3
seconds. This make it impossible to write profile data when vdsm is
terminated. On systemd, since no timeout was defined, the default 90
seconds timeout was used. On upstart, the default 5 seconds was used.

This patch normalizes the shutdown timeout to 10 seconds on all
platforms. This seems to be enough for saving profile data and
performing clean shutdown.

Change-Id: I5434caff5bc95e2a76345191dec9ce4e33070a57
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/26111
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M configure.ac
M init/systemd/vdsmd.service.in
M init/sysvinit/vdsmd.init.in
M init/upstart/vdsmd.upstart.in
4 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26111
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5434caff5bc95e2a76345191dec9ce4e33070a57
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika at gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list