Change in vdsm[master]: clientIF: Clean up shutdown process

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 31 16:39:51 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: clientIF: Clean up shutdown process
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26112/3/vdsm/vdsm
File vdsm/vdsm:

Line 48: 
Line 49: def serve_clients(log):
Line 50:     cif = None
Line 51:     irs = None
Line 52:     running = [True]
> I love pointers....
Ugly, but required to keep the changes minimal. I can make cif, irs, and running private globals if you like, in a separate patch.
Line 53: 
Line 54:     def sigtermHandler(signum, frame):
Line 55:         log.debug("Received signal %s" % signum)
Line 56:         running[0] = False


-- 
To view, visit http://gerrit.ovirt.org/26112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7bfa9f7da81ffdfb581299cd14ec4edb50be5fb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list