Change in vdsm[master]: VmStatsThread: make _getNicStats testable

danken at redhat.com danken at redhat.com
Mon Mar 31 16:20:00 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: VmStatsThread: make _getNicStats testable
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/25982/6/tests/vmTests.py
File tests/vmTests.py:

Line 809:             mock_stats_thread = vm.VmStatsThread(fake)
Line 810:             res = mock_stats_thread._getNicStats(
Line 811:                 name='vnettest', model='virtio', mac=MAC,
Line 812:                 start_sample=(2 ** 64 - 15 * GBPS, 1, 2, 3, 0, 4, 5, 6),
Line 813:                 end_sample=(0, 7, 8, 9, 5 * GBPS, 10, 11, 12),
> Unrelated and for later patch, but this just caught my eye.
Or conversely, profile if we'd be better off accessing sysfs directly.
Line 814:                 interval=15.0)
Line 815:             self.assertEqual(res, {
Line 816:                 'rxErrors': '8', 'rxDropped': '9',
Line 817:                 'txErrors': '11', 'txDropped': '12',


-- 
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list