Change in vdsm[master]: init: Normalize shutdown timeout

mperina at redhat.com mperina at redhat.com
Mon Mar 31 12:56:05 UTC 2014


Martin Peřina has posted comments on this change.

Change subject: init: Normalize shutdown timeout
......................................................................


Patch Set 3:

> Does engine timeout starts after vdsm restart command finished? Because if it does, it means that this happens after vdsm was stopped (and optionally killed), and from engine point of view, it does not matter what is our stop timeout.
>So in this case, we can enlarge the timeout to 60 seconds without effecting engine. The only effect would be that when a host is overloaded, vdsm may shutdown slower, enlarging the time it takes to move a highly-available vm to another machine.
>What do you think?

Well, it's a bit more complicated:

1) This timeout is calculated when network exception occurred during getVdsStats 

2) This timeout is added to time of last successfull getVdsStats call for the host

3) If current time is greater then lastSuccess + timeout, then SSH Soft Fencing is executed

4) When network exception occurred during next getVdsStats, the timeout is doubled since
   SSH Soft Fencing was executed

5) If current time is greater then lastSuccess + timeout, then real fencing is executed


So in current engine code we don't assume that restarting vdsm could take significant amount of time and if restarting vdsm would take 60 seconds, it may be possible that real fencing would be executed too early. If you really want to enlarge vdsm restart timeout to 60 seconds, the engine code should be updated to add vdsm restart execution time to its fencing timeout.

-- 
To view, visit http://gerrit.ovirt.org/26111
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5434caff5bc95e2a76345191dec9ce4e33070a57
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika at gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list