Change in vdsm[master]: iscsi: Specify tpgt to impose creation of a new style node r...

danken at redhat.com danken at redhat.com
Sun Mar 30 11:33:41 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: iscsi: Specify tpgt to impose creation of a new style node record
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/25706/5/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 177: 
Line 178:     # Basically this command deleting a node record (see addIscsiNode).
Line 179:     # Once we create a record in the new style format by specifying a tpgt,
Line 180:     # we delete it in the same way.
Line 181:     portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port,
What would happen if addIscsiNode() is called by an older Vdsm, and then Vdsm is upgraded to this code? Would removeIscsiNode() succeed?
Line 182:                               target.tpgt)
Line 183:     with _iscsiadmTransactionLock:
Line 184:         try:
Line 185:             iscsiadm.node_disconnect(iface.name, portalStr, targetName)


-- 
To view, visit http://gerrit.ovirt.org/25706
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list