Change in vdsm[master]: util: fix execCmd to accept tuples

nsoffer at redhat.com nsoffer at redhat.com
Sat Mar 29 23:34:55 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: util: fix execCmd to accept tuples
......................................................................


Patch Set 4:

(1 comment)

Note about "faster"

http://gerrit.ovirt.org/#/c/26070/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 652:     IMPORTANT NOTE: the new process would receive `deathSignal` when the
Line 653:     controlling thread dies, which may not be what you intended: if you create
Line 654:     a temporary thread, spawn a sync=False sub-process, and have the thread
Line 655:     finish, the new subprocess would die immediately.
Line 656:     """
> you're right, for some reason I though that chain would be faster but surpr
Even if using chain was faster, it is does not matter, unless you can prove using a profiler that this is a bottleneck. What matters is the simplicity and readability of the code.
Line 657:     if ioclass is not None:
Line 658:         cmd = command
Line 659:         command = [constants.EXT_IONICE, '-c', str(ioclass)]
Line 660:         if ioclassdata is not None:


-- 
To view, visit http://gerrit.ovirt.org/26070
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list