Change in vdsm[master]: util: fix execCmd to accept tuples

nsoffer at redhat.com nsoffer at redhat.com
Sat Mar 29 23:16:29 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: util: fix execCmd to accept tuples
......................................................................


Patch Set 5: -Code-Review

(1 comment)

http://gerrit.ovirt.org/#/c/26070/5/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 674:     if sudo:
Line 675:         if os.geteuid() != 0:
Line 676:             command = [constants.EXT_SUDO, SUDO_NON_INTERACTIVE_FLAG] + command
Line 677: 
Line 678:     command = tuple(command)
> Nir, Dima: please explain why the added
Now I see that it was added - I probably should invest more time before I wrote my comment :-)

Dima, how is converting the command to a tuple required for supporting tuples as input?
Line 679:     if not printable:
Line 680:         printable = command
Line 681: 
Line 682:     cmdline = repr(subprocess.list2cmdline(printable))


-- 
To view, visit http://gerrit.ovirt.org/26070
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list