Change in vdsm[master]: init: Normalize shutdown timeout

Alon Bar-Lev alonbl at redhat.com
Fri Mar 28 20:42:25 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: init: Normalize shutdown timeout
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26111/2/init/sysvinit/vdsmd.init.in
File init/sysvinit/vdsmd.init.in:

Line 137:         log_failure_msg "$prog: not running"
Line 138:         RETVAL=0
Line 139:     else
Line 140:         # Give process enough time for saving profiling data
Line 141:         killproc -p "$PIDFILE" -d 10
> Something like this?
there is reason to commit something and fix it at next patch if it can be fixed in this one. especially trivial issues like the above.
Line 142:         RETVAL=$?
Line 143:         [ "$RETVAL" = 0 ] && "@RM_PATH@" -f "$LOCK_FILE" > /dev/null 2>&1
Line 144:     fi
Line 145:     "${VDSMD_INIT_COMMON}" --post-stop


-- 
To view, visit http://gerrit.ovirt.org/26111
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5434caff5bc95e2a76345191dec9ce4e33070a57
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list