Change in vdsm[master]: tests: make virtTests run on RHEL/CentOS

asegurap at redhat.com asegurap at redhat.com
Fri Mar 28 16:10:18 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: make virtTests run on RHEL/CentOS
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26198/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:

Line 282:     def testVmWithCdrom(self, pathLocation):
Line 283:         customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Line 284:                          'devices': [],
Line 285:                          'vmName':
Line 286:                          ('testVmWithCdrom_{0}').format(pathLocation)}
Since almost all the codebase uses % formatting and we agreed on that, maybe the fix here is to use that instead of a 2.6 only fix.
Line 287: 
Line 288:         # echo -n testPayload | md5sum
Line 289:         # d37e46c24c78b1aed33496107afdb44b
Line 290:         vmPayloadName = ('/var/run/vdsm/payload/{0}.'


-- 
To view, visit http://gerrit.ovirt.org/26198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I248acbf03fa86585b74e3c6e8c76afe31561663d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list