Change in vdsm[master]: performance: switch to cPickle

danken at redhat.com danken at redhat.com
Fri Mar 28 16:07:59 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: performance: switch to cPickle
......................................................................


performance: switch to cPickle

profiling of the creation code path shows
that the impact of pickle is not negligible.

cPickle is a safe drop-in replacement, so this
patch switch to it for the sake of performance.

considering a 'monday morning' scenario (mass parallel
start of many VMs) we see ~5% improvement in startup time

before:
mean: 27.984s stdev=1.074s
best: 10.507s stdev=1.604s
worst: 42.711s stdev=1.996s
total: 895.479s stdev=34.375s

after:
mean: 26.423s stdev=1.413s
best: 9.785s stdev=1.669s
worst: 40.833s stdev=2.452s
total: 845.523s stdev=45.218s

pickle is used to save the VM params for checkpointing,
so the benefits should affect, possibly with lower extent,
to all VM operation flows.

Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25860
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/API.py
M vdsm/clientIF.py
M vdsm/storage/remoteFileHandler.py
M vdsm/storage/storageServer.py
M vdsm/virt/vm.py
5 files changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/25860
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list