Change in vdsm[master]: vm: avoid to reply with half-baked statistics

fromani at redhat.com fromani at redhat.com
Fri Mar 28 15:44:14 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: avoid to reply with half-baked statistics
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py
File vdsm/vm.py:

Line 2815:             stats['hash'] = self._devXmlHash
Line 2816:             if self._watchdogEvent:
Line 2817:                 stats["watchdogEvent"] = self._watchdogEvent
Line 2818:         except Exception:
Line 2819:             self.log.error("Error fetching vm stats", exc_info=True)
> what I meant is that partial stats may make sense. But we can only return t
Ok, will verify on the engine side.
Line 2820:             stats = {}
Line 2821:         return stats
Line 2822: 
Line 2823:     def _getStatsInternal(self):


-- 
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list