Change in vdsm[master]: virt: migration: move threads in a separate module

asegurap at redhat.com asegurap at redhat.com
Fri Mar 28 15:30:48 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: virt: migration: move threads in a separate module
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

Minor local import change.

http://gerrit.ovirt.org/#/c/25970/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 29: from vdsm import utils
Line 30: from vdsm import vdscli
Line 31: from vdsm.config import config
Line 32: from vdsm.define import NORMAL, errCode, Mbytes
Line 33: import vmexitreason
shouldn't this be:
from . import vmexitreason
?
Line 34: 
Line 35: 
Line 36: class MigrationSourceThread(threading.Thread):
Line 37:     """


-- 
To view, visit http://gerrit.ovirt.org/25970
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list