Change in vdsm[master]: core: Add boot time to the getVdsStats API
nsoffer at redhat.com
nsoffer at redhat.com
Fri Mar 28 12:54:23 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/6/tests/samplingTests.py
File tests/samplingTests.py:
Line 60: os.remove(path)
Line 61:
Line 62: def testBootTimeEmpty(self):
Line 63: with self.assertRaises(IndexError):
Line 64: sampling.getBootTime('/dev/null')
This test document the wrong error handling in this code. Does it make sense that getBootTime raise an IndexError?
This error is just a side effect of the current implementation, and should not be part of the api.
Line 65:
Line 66: def testBootTimeMalformed(self):
Line 67: (f, path) = tempfile.mkstemp()
Line 68: os.write(f, self.boot_time_fixture_bad)
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list