Change in vdsm[master]: clientIF: Clean up shutdown process

nsoffer at redhat.com nsoffer at redhat.com
Fri Mar 28 00:48:50 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: clientIF: Clean up shutdown process
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26112/2/vdsm/vdsm
File vdsm/vdsm:

Line 77:     cif = clientIF.getInstance(irs, log)
Line 78:     cif.start()
Line 79:     try:
Line 80:         while running[0]:
Line 81:             signal.pause()
Yaniv was concerned about signal.pause() returning *before* the signal handler was called. Python documentation is not clear about this, so I check the code in the Python 2.6 branch, and I can confirm that this is impossible.

See Modules/signalmodule.c.
Line 82:     finally:
Line 83:         cif.prepareForShutdown()
Line 84: 
Line 85: 


-- 
To view, visit http://gerrit.ovirt.org/26112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7bfa9f7da81ffdfb581299cd14ec4edb50be5fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list