Change in vdsm[master]: util: fix execCmd to accept tuples

danken at redhat.com danken at redhat.com
Thu Mar 27 18:33:22 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: util: fix execCmd to accept tuples
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/26070/4/tests/utilsTests.py
File tests/utilsTests.py:

Line 469: 
Line 470:     def __init__(self, *args, **kwargs):
Line 471:         TestCaseBase.__init__(self, *args, **kwargs)
Line 472: 
Line 473:         self.patch = Patch([(cpopen, 'CPopen', self.patchedCPopen),
> I feel responsible, having suggested monkey-patching...
strike the last part - touching a root-owned file would succeed anyway, if we run the test as root.
Line 474:                             (utils, 'AsyncProc', self.patchedAsyncProc)])
Line 475: 
Line 476:     def setUp(self):
Line 477:         self.patch.apply()


-- 
To view, visit http://gerrit.ovirt.org/26070
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list