Change in vdsm[master]: Add logging to rules operations in supervdsmServer

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 27 14:49:38 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Add logging to rules operations in supervdsmServer
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26121/3//COMMIT_MSG
Commit Message:

Line 11: or removing rules.
Line 12: 
Line 13: Although most of the operations are logged through the
Line 14: logDecorator the udev rules creation and deletion are not
Line 15: logged per rule.
> I'd also appreciate a note on why these logs are useful - have yo encounter
I remember vaguely issues related with the udev rules, but I could not prove anything because we did not have proper logging, and after the rules are removed, you have no clue what happened on the machine. This patch eliminates such issues.

Anyway the purpose of this patches (more on the way) is to make it easier and faster to debug issues, so when we have a problem in the field, we can respond much faster than we can today.
Line 16: 
Line 17: Change-Id: Ib1d8ede0cbe0790bdfcd60ed833b3d9c54f31eba


-- 
To view, visit http://gerrit.ovirt.org/26121
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d8ede0cbe0790bdfcd60ed833b3d9c54f31eba
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list