Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure

mtayer at redhat.com mtayer at redhat.com
Thu Mar 27 14:38:00 UTC 2014


mooli tayer has posted comments on this change.

Change subject: Initial commit for vdsm-tool testing infrastructure
......................................................................


Patch Set 20:

(2 comments)

http://gerrit.ovirt.org/#/c/25263/20/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 80:                     env[k] = v
Line 81:             except UnicodeDecodeError:
Line 82:                 pass
Line 83:         rc, out, err = utils.execCmd(
Line 84:             self._get_libvirt_exec() + (action,), env=env, raw=True
> shouldn't it be 
I think that would not work in test since there
 _get_libvirt_exec() returns a tuple.
Line 85:         )
Line 86: 
Line 87:         sys.stdout.write(out)
Line 88:         sys.stderr.write(err)


Line 89:         if rc != 0:
Line 90:             raise RuntimeError("Failed to perform libvirt action.")
Line 91: 
Line 92:     def _get_libvirt_exec(self):
Line 93:         return os.path.join(P_VDSM_EXEC, 'libvirt_configure.sh'),
> because the comma at the end it returns tuple and not string... it confused
ok
Line 94: 
Line 95:     def configure(self):
Line 96:         self._exec_libvirt_configure("reconfigure")
Line 97: 


-- 
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0fec9b2057c5ba932f38ed5d34d654486043ef
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list