Change in vdsm[master]: drop ominous log for libvirt errors

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Mar 27 13:25:11 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: drop ominous log for libvirt errors
......................................................................


Patch Set 1:

If we wouldn't swallow so many exceptions all over the place, I wouldn't have a problem with that. But vdsm is full of except/pass lines where we would never know if anything like this was reported. This is now a debug message and it is harmless in comparison the amount of messages which come from storage for example.

There were moments which would have made our lives enormously easier with having this log line. Especially when libvirt is changing/adding error codes. In those cases it's pretty hard to understand why something that used to work does not work any longer and this is the reason why we put this log in place. I honestly do not understand the aversion of this. There's probably much more less useful stuff logged in vdsm and this is the item I am insisting to keep it.

And it doesn't matter if in the past 11 months there was no such instance happening again. My prime reason is the commit I introduced this for. 
Look how long it took to realize what the problem is in the bug related to that original commit: https://bugzilla.redhat.com/show_bug.cgi?id=852956

It's more than half a year before we figured out what was the real deal. If we would have had the codes somewhere logged we could have seen some potential difference. Especially the difference between the libvirt version on Fedora and on RHEL. They are quite far apart even if features get backported.

-- 
To view, visit http://gerrit.ovirt.org/17324
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd2a53ffee7fb78cb1c8d171093e93e233ed5ad4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list