Change in vdsm[master]: vm: avoid to reply with half-baked statistics

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Mar 27 13:20:04 UTC 2014


Omer Frenkel has posted comments on this change.

Change subject: vm: avoid to reply with half-baked statistics
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:

Line 362:         if not v:
Line 363:             return errCode['noVM']
Line 364:         stats = v.getStats().copy()
Line 365:         if not stats:
Line 366:             return errCode['down']
> I am not sure that this is the right response
from engine POV, if vdsm say vm is down, its down, and it can be run again.
if you are not sure, its better to return an error.
engine (now..) handles error in getVmStats by ignoring it, keeping old vm state, and trying again on next monitoring cycle, so if this is a race, and on next getVmStats vdsm will return the correct vm state, its better.
Line 367:         stats['vmId'] = self._UUID
Line 368:         return {'status': doneCode, 'statsList': [stats]}
Line 369: 
Line 370:     def hibernate(self, hibernationVolHandle):


-- 
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list