Change in vdsm[master]: Add logging to rules operations in supervdsmServer

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 27 12:26:05 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Add logging to rules operations in supervdsmServer
......................................................................


Patch Set 3:

(2 comments)

Commit message needs more love.

http://gerrit.ovirt.org/#/c/26121/3//COMMIT_MSG
Commit Message:

Line 7: Add logging to rules operations in supervdsmServer
Line 8: 
Line 9: The motivation of this patch is to increase the logging of some
Line 10: filesystem related operations in supervdsmServer when creating
Line 11: or removing rules.
This is not correct
- There is no logging when creating or removing rules - this contradict the title.
- It is not about some filesystem operations but about creating and removing udev rules.
Line 12: 
Line 13: Although most of the operations are logged through the
Line 14: logDecorator the udev rules creation and deletion are not
Line 15: logged per rule.


Line 11: or removing rules.
Line 12: 
Line 13: Although most of the operations are logged through the
Line 14: logDecorator the udev rules creation and deletion are not
Line 15: logged per rule.
The general text should be replaced with specific text abut this small change.
Line 16: 
Line 17: Change-Id: Ib1d8ede0cbe0790bdfcd60ed833b3d9c54f31eba


-- 
To view, visit http://gerrit.ovirt.org/26121
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d8ede0cbe0790bdfcd60ed833b3d9c54f31eba
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list