Change in vdsm[master]: caps: report if QEMU supports live snapshots
fromani at redhat.com
fromani at redhat.com
Thu Mar 27 11:49:03 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26149/1/vdsm/caps.py
File vdsm/caps.py:
Line 181: capabilities = _getCapsXMLStr()
Line 182: caps = minidom.parseString(capabilities)
Line 183:
Line 184: for guestTag in caps.getElementsByTagName('guest'):
Line 185: archTag = guestTag.getElementsByTagName('arch')[0]
> is PPC relevant here?
It should be handled by the caller, and now I wonder why tests passed.
Line 186: if archTag.getAttribute('name') == arch:
Line 187: return _findLiveSnapshotSupport(guestTag)
Line 188: return False
Line 189:
--
To view, visit http://gerrit.ovirt.org/26149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78dd51fc72f1b6d7eadb5c18d3b768f42d8ee32b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list