Change in vdsm[master]: Add logging to fs operations in supervdsmServer

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 27 09:43:08 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Add logging to fs operations in supervdsmServer
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26121/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 266:         ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
Line 267:         rule = 'SYMLINK=="mapper/%s", OWNER="%s", GROUP="%s"\n' % (guid,
Line 268:                DISKIMAGE_USER, DISKIMAGE_GROUP)
Line 269:         with open(ruleFile, "w") as rf:
Line 270:             self.log.debug("Creating rule %s", rule)
Lets add the ruleFile to the log, probably before the rule data.
Line 271:             rf.write(rule)
Line 272: 
Line 273:     @logDecorator
Line 274:     def rmAppropriateRules(self, thiefId):


-- 
To view, visit http://gerrit.ovirt.org/26121
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d8ede0cbe0790bdfcd60ed833b3d9c54f31eba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list