Change in vdsm[master]: hooks: Add hook for fake VM stats

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Mar 27 07:21:42 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: hooks: Add hook for fake VM stats
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/25927/9/vdsm_hooks/fakevmstats/after_get_all_vm_stats.py
File vdsm_hooks/fakevmstats/after_get_all_vm_stats.py:

Line 62: methods
I am not sure but for the sake of functionality you should report the ovirt-guest-agent-common package. 
The engine is using this as an indicator that the guest agent is installed. Some functionality would not work without that. For example SSO requests wouldn't be send by the engine when the guest agent package is not detected.


-- 
To view, visit http://gerrit.ovirt.org/25927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list