Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

dougsland at redhat.com dougsland at redhat.com
Wed Mar 26 22:33:24 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 2:

(8 comments)

Hello Yeela, few comments.

http://gerrit.ovirt.org/#/c/26123/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 170: 
Line 171:         return ret
Line 172: 
Line 173: 
Line 174: MPATH_CONF = "/etc/multipath.conf"
If this variable is internal only use, probably we want to start with underscore. _MPATH_CONF.
Line 175: 
Line 176: STRG_MPATH_CONF = (
Line 177:     "\n\n"
Line 178:     "defaults {\n"


Line 172: 
Line 173: 
Line 174: MPATH_CONF = "/etc/multipath.conf"
Line 175: 
Line 176: STRG_MPATH_CONF = (
If this variable is internal only use, probably we want to start with underscore. _STRG_MPATH_CONF.
Line 177:     "\n\n"
Line 178:     "defaults {\n"
Line 179:     "    polling_interval        5\n"
Line 180:     "    getuid_callout          \"%(scsi_id_path)s --whitelisted "


Line 201:     "}\n"
Line 202:     "}"
Line 203: )
Line 204: 
Line 205: OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3",
same here as above.
Line 206:             "# RHEV REVISION 0.4", "# RHEV REVISION 0.5",
Line 207:             "# RHEV REVISION 0.6", "# RHEV REVISION 0.7",
Line 208:             "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
Line 209: MPATH_CONF_TAG = "# RHEV REVISION 1.0"


Line 205: OLD_TAGS = ["# RHAT REVISION 0.2", "# RHEV REVISION 0.3",
Line 206:             "# RHEV REVISION 0.4", "# RHEV REVISION 0.5",
Line 207:             "# RHEV REVISION 0.6", "# RHEV REVISION 0.7",
Line 208:             "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
Line 209: MPATH_CONF_TAG = "# RHEV REVISION 1.0"
same here as above.
Line 210: MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
Line 211: 
Line 212: MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + STRG_MPATH_CONF
Line 213: 


Line 206:             "# RHEV REVISION 0.4", "# RHEV REVISION 0.5",
Line 207:             "# RHEV REVISION 0.6", "# RHEV REVISION 0.7",
Line 208:             "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
Line 209: MPATH_CONF_TAG = "# RHEV REVISION 1.0"
Line 210: MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
same here as above.
Line 211: 
Line 212: MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + STRG_MPATH_CONF
Line 213: 
Line 214: MAX_CONF_COPIES = 5


Line 208:             "# RHEV REVISION 0.8", "# RHEV REVISION 0.9"]
Line 209: MPATH_CONF_TAG = "# RHEV REVISION 1.0"
Line 210: MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
Line 211: 
Line 212: MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + STRG_MPATH_CONF
same here as above.
Line 213: 
Line 214: MAX_CONF_COPIES = 5
Line 215: 
Line 216: _scsi_id = utils.CommandPath("scsi_id",


Line 210: MPATH_CONF_PRIVATE_TAG = "# RHEV PRIVATE"
Line 211: 
Line 212: MPATH_CONF_TEMPLATE = MPATH_CONF_TAG + STRG_MPATH_CONF
Line 213: 
Line 214: MAX_CONF_COPIES = 5
same here as above.
Line 215: 
Line 216: _scsi_id = utils.CommandPath("scsi_id",
Line 217:                          "/sbin/scsi_id",  # EL6
Line 218:                          "/usr/lib/udev/scsi_id",  # Fedora


http://gerrit.ovirt.org/#/c/26123/2/vdsm/caps.py
File vdsm/caps.py:

Line 456
Line 457
Line 458
Line 459
Line 460
I don't think that's a good thing to do, what about old systems calling caps?

Probably should be:
def isOvirtNode():
   return utils.isOvirtNode()

BTW, I am glad to see this code moving to utils. I tried that myself too: http://gerrit.ovirt.org/#/c/25974


-- 
To view, visit http://gerrit.ovirt.org/26123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40f802477e39000c5cae01a496ac2d9f879ebfa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list