Change in vdsm[master]: vm: avoid to reply with half-baked statistics

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Mar 26 07:22:54 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: vm: avoid to reply with half-baked statistics
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:

Line 366: ['
I am not sure that this is the right response
If memory serves me well this response would cause trouble.

What is if we just lost the connection to libvirt and that's why we had an exception, the next time the engine polls the VM is suddenly up again. This might actually result in a split brain for HA vms.

IMHO, we should discuss the right response for this scenario with the engine guys.


-- 
To view, visit http://gerrit.ovirt.org/25803
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list