Change in vdsm[master]: Allow moving of sparse images to a block domains

tnisan at redhat.com tnisan at redhat.com
Tue Mar 25 16:10:46 UTC 2014


Tal Nisan has posted comments on this change.

Change subject: Allow moving of sparse images to a block domains
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 380:                     dstVol.extend((volParams['apparentsize'] + 511) / 512)
Line 381: 
Line 382:                     # Change destination volume metadata back to the original
Line 383:                     # type unless the domain does not supports sparseness, in
Line 384:                     # that case leave it as preallocated
> Probably you need to update the comment.
Done
Line 385:                     if volParams['prealloc'] == volume.PREALLOCATED_VOL \
Line 386:                             and tmpVolPreallocation != volume.PREALLOCATED_VOL:
Line 387:                         dstVol.setType(volume.PREALLOCATED_VOL)
Line 388: 


-- 
To view, visit http://gerrit.ovirt.org/25778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list