Change in vdsm[master]: recovery: try to restore VMs from recovery files
danken at redhat.com
danken at redhat.com
Tue Mar 25 09:02:09 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
Please include a functional test, that starts a Vm, stops Vdsm, kills qemu, and verifies that the kill Vm is reported back as Down.
http://gerrit.ovirt.org/#/c/25276/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-03-03 15:06:09 +0100
Line 6:
Line 7: recovery: try to restore VMs from recovery files
Line 8:
Line 9: on recovery, VDSM tries to recover the all the VMs reported
English: the all the
Line 10: as active by libvirt.
Line 11: If a VM disappears while VDSM is down or restarting, the
Line 12: VM silently disappears without VDSM noticing, and the recovery
Line 13: file is discarded.
http://gerrit.ovirt.org/#/c/25276/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 419: # we do this to safely handle VMs which disappeared
Line 420: # from the host while VDSM was down/restarting
Line 421: for vmId in self._getVDSMVmsFromRecovery():
Line 422: if not self._recoverVm(vmId):
Line 423: self.log.info('expected VM %s from recovery file but'
Where is a new VM object created and added to vmContainer in Down state?
Line 424: 'missing, reported as Down', vmId)
Line 425:
Line 426: while (self._enabled and
Line 427: 'WaitForLaunch' in [v.lastStatus for v in
--
To view, visit http://gerrit.ovirt.org/25276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list