Change in vdsm[master]: tools: configurator must persist usermod changes

dougsland at redhat.com dougsland at redhat.com
Tue Mar 25 04:28:43 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: tools: configurator must persist usermod changes
......................................................................


Patch Set 4:

(1 comment)

Ok, create another patch to move to spec file. I think the best test is generate a ovirt-node and test it.
http://gerrit.ovirt.org/#/c/26055/

However, will need this one as well:
http://gerrit.ovirt.org/#/c/25912/

http://gerrit.ovirt.org/#/c/25974/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 149:                 ),
Line 150:                 raw=True,
Line 151:             )
Line 152:             if rc != 0:
Line 153:                 raise RuntimeError("Failed to persist sanlock config.")
> put afterwards sys.stdout.write(out) and sys.stderr.write(err)
agreed but looks like this patch won't be merged in favor of moving to spec. In case we go with this approach I can add sys.stdout.write and sys.stderr.write
Line 154: 
Line 155:     def isconfigured(self):
Line 156:         """
Line 157:         True if sanlock service is configured, False if sanlock service


-- 
To view, visit http://gerrit.ovirt.org/25974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list