Change in vdsm[master]: Improve logging on some filesystem operations

amureini at redhat.com amureini at redhat.com
Mon Mar 24 20:46:25 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: Improve logging on some filesystem operations
......................................................................


Patch Set 2:

(1 comment)

General comment - it's usually better to log /before/ performing an operation (or at least, also log before). Storage operations can hang, and in that case we'll be unable to determine where they hung from the log.

http://gerrit.ovirt.org/#/c/26046/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Improve logging on some filesystem operations
Line 8: 
Line 9: The rationale behind this patch is to increase the logging on some
Line 10: filesystem operations. Before no trace was given when creating or
"storage operations", not "filesystem operations". Note that you're also changing blockSD.py
Line 11: deleting symbolic links or removing or renaming files or folders in
Line 12: storage operations. This patch tries to solve this adding debug
Line 13: messages after those operations succeed.
Line 14: 


-- 
To view, visit http://gerrit.ovirt.org/26046
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3602513af123951f71091c03f799e36ea759aa61
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xavi Francisco <xfrancis at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list